Re: Backup history file should be replicated in Streaming Replication?
Simon Riggs <simon@2ndquadrant.com>
From: Simon Riggs <simon@2ndQuadrant.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2009-12-22T18:41:20Z
Lists: pgsql-hackers
On Wed, 2009-12-23 at 03:28 +0900, Fujii Masao wrote: > On Wed, Dec 23, 2009 at 2:42 AM, Simon Riggs <simon@2ndquadrant.com> wrote: > > The backup history file is a slightly bit quirky way of doing things and > > was designed when the transfer mechanism was file-based. > > > > Why don't we just write a new xlog record that contains the information > > we need? Copy the contents of the backup history file into the WAL > > record, just like we do with prepared transactions. That way it will be > > streamed to the standby without any other code being needed for SR, > > while we don't need to retest warm standby to check that still works > > also. > > This means that we can replace a backup history file with the corresponding > xlog record. I think that we should simplify the code by making the replacement > completely rather than just adding new xlog record. Thought? We can't do that because it would stop file-based archiving from working. I don't think we should deprecate that for another release at least. -- Simon Riggs www.2ndQuadrant.com