Re: Small Bug in GetConflictingVirtualXIDs

Simon Riggs <simon@2ndquadrant.com>

From: Simon Riggs <simon@2ndQuadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Date: 2009-12-21T07:46:39Z
Lists: pgsql-hackers
On Mon, 2009-12-21 at 04:02 +0100, Andres Freund wrote:

> The logic behind this seems fine except in the case of dropping a database. 
> There you very well might have a open connection without an open snapshot.

Yes, you're right, thanks for the report. 

I re-arranged the logic there recently to reduce the number of backends
that would conflict, so it looks like I broke that case when I did
that. 

> Should easily be solvable through an extra parameter for 
> GetConflictingVirtualXIDs. Want me to prepare a patch?

Much appreciated, thanks.

-- 
 Simon Riggs           www.2ndQuadrant.com