Re: enable-thread-safety defaults?

Peter Eisentraut <peter_e@gmx.net>

From: Peter Eisentraut <peter_e@gmx.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2009-12-10T22:58:19Z
Lists: pgsql-hackers
On tis, 2009-12-01 at 18:03 -0500, Bruce Momjian wrote:
> Tom Lane wrote:
> > Magnus Hagander <magnus@hagander.net> writes:
> > > 2009/12/1 Bruce Momjian <bruce@momjian.us>:
> > >> What are we going to do for build farm members who don't support
> > >> threading? Is someone going to manually update their configure flags?
> > 
> > > Yeah, I think so.
> > 
> > > Unless there's a whole lot of them, in which case we revert the patch.
> > 
> > It would seem like we ought to try the one-liner patch Magnus proposed
> > (ie flip the default) and see what the effects are, before we go with
> > the much larger patch Bruce wrote.
> 
> OK, done --- let the breakage begin.  (I will be monitoring the build
> farm and will work with Andrew Dunstan on any issues.)

You have removed all the configure code that defined
ENABLE_THREAD_SAFETY, but there is still lots and lots of code that
checks for #ifdef ENABLE_THREAD_SAFETY.  So this is is probably quite
broken at the moment.