Horton

Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2019-12-19T20:09:45Z
Lists: pgsql-bugs 
Alexander Lakhin <exclusion@gmail.com> writes:
> Maybe we should change the condition to 'if (stat(fileName, &st) != 0 &&
> (err = GetLastError()) == ERROR_ACCESS_DENIED)' to avoid unnecessary
> sleep with a loop iteration...

Well, we have to loop back on file-not-found too ...

> It seems that the check for ERROR_DELETE_PENDING was added to
> pgwin32_safestat() blindly, the issue wasn't reproduced at that time:
> https://www.postgresql.org/message-id/CAB7nPqRJV6trFta-Qzgi6j2feuYR2ZC%2BKHvWdHnbpDG2scTrxw%40mail.gmail.com

Hmm, makes one wonder whether that's actually live code.

			regards, tom lane

Commits

  1. In pgwin32_open, loop after ERROR_ACCESS_DENIED only if we can't stat.

  2. On Windows, wait a little to see if ERROR_ACCESS_DENIED goes away.