Re: unknown libpq service entries ignored
Peter Eisentraut <peter_e@gmx.net>
From: Peter Eisentraut <peter_e@gmx.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: 2009-11-27T22:16:09Z
Lists: pgsql-hackers
On fre, 2009-11-27 at 10:22 -0500, Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > + printfPQExpBuffer(errorMessage,
> > + libpq_gettext("ERROR: service \"%s\" not found\n"), service);
>
> Please make the message consistent with the rest of libpq. AFAICS none
> of the other messages in that file use an ERROR: prefix.
Well, that style is used four times in that same function, but no where
else in the file. So the existing uses should probably also be cleaned
up.