Re: [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Daniel Farina <drfarina@gmail.com>, Hannu Krosing <hannu@krosing.net>, Greg Smith <greg@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Daniel Farina <dfarina@truviso.com>, pgsql-hackers@postgresql.org
Date: 2009-11-25T04:16:20Z
Lists: pgsql-hackers
On Tue, 2009-11-24 at 14:39 +0100, Pavel Stehule wrote:
> a) good designed C API  like:
> 
>    initialise_functions(fcinfo) -- std fcinfo
>    consument_process_tuple(fcinfo) -- gets standard row -- Datum
> dvalues[] + Row description
>    producent_process_tuple(fcinfo) -- returns standard row  -- Datum
> dvalues[] + Row description (look on SRF API)
>    terminate_funnction(fcinfo)
> 

Don't you still need the functions to accept an argument of type
internal? Otherwise, we lose the ability to copy a buffer to the dblink
connection, which was the original motivation.

Regards,
	Jeff Davis