Horton

Re: BUG #17828: postgres_fdw leaks file descriptors on error and aborts aborted transaction in lack of fds

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Etsuro Fujita <etsuro.fujita@gmail.com>, Alexander Lakhin <exclusion@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2024-02-08T22:06:46Z
Lists: pgsql-bugs 
Andres Freund <andres@anarazel.de> writes:
> I also wonder if postgres_fdw should strive to use a longer lived wait event
> set. For efficiency, if nothing else? That'd avoid the need to create one
> during error handling.

Seems like a plausible idea.  Having to acquire resources to clean up
an error is an anti-pattern for sure.

			regards, tom lane

Commits

  1. Fix resource leak when a FDW's ForeignAsyncRequest function fails