Re: convert libpq uri-regress tests to tap test

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@postgresql.org
Date: 2022-02-23T22:03:56Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2022-Feb-23, Andres Freund wrote:
>> Separately: I don't really understand why we do the whole if USE_PGXS dance in
>> src/test/modules?

> Yeah, it seems a bit silly.  I'm not opposed to making these makefiles
> unconditionally do the PGXS thing -- or the non-PGXS thing, if that
> makes it easier to build multiple binaries.

Agreed, we could easily lose that.  I think we only do it in contrib
to serve as an example of how to use PGXS ... although considering
we're not *testing* that build mode, one wonders how much that proves.
In any case, src/test/modules doesn't have to do it.

			regards, tom lane



Commits

  1. Run tests of libpq on installcheck-world, checkprep and check-world

  2. Convert src/interfaces/libpq/test to a tap test.

  3. Run tap tests in src/interfaces/libpq.