Re: Fix a wrong comment in load_file()

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: cca5507 <cca5507@qq.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-12-23T03:50:47Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Dec 23, 2024 at 10:58:49AM +0800, cca5507 wrote:
>   * This function loads a shlib file without looking up any particular
>   * function in it.  If the same shlib has previously been loaded,
> - * unload and reload it.
> + * we don't load it again.

> Right.  This comment is misleading.

I think it was once correct, decades ago.  Obviously we missed
fixing it when we ripped out the unload functionality.

> -	/* Load the shared library */
> +	/* Load the shared library, unless we already did */

> This comment is still true, though.

Seems like an improvement to me?

			regards, tom lane



Commits

  1. Fix some comments related to library unloading