Horton

Re: BUG #15892: URGENT: Using an ICU collation in a primary key column breaks ILIKE query

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Arthur Zakirov <a.zakirov@postgrespro.ru>
Cc: Daniel Verite <daniel@manitou-mail.org>, James Inform <james.inform@pharmapp.de>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-bugs@lists.postgresql.org
Date: 2019-08-12T17:17:38Z
Lists: pgsql-bugs 
Arthur Zakirov <a.zakirov@postgrespro.ru> writes:
> On 12.08.2019 00:32, Tom Lane wrote:
>> I think Daniel's patch leaves more on the table than it needs to,
>> and I don't like Arthur's patch because it's assuming more than it
>> should about whether it's okay to pass a "char" to u_isalpha().
>> I propose that we do things as attached, instead.

> Yeah, u_isalpha() wasn't such good idea here. BTW Daniel already 
> mentioned it above.
> With the patch regression tests pass for me and James test case works 
> fine as expected.

Thanks for double-checking!  Pushed now.

			regards, tom lane

Commits

  1. Fix planner's test for case-foldable characters in ILIKE with ICU.