Horton

Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, Victor Wagner <vitus@wagner.pp.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-12-01T22:28:54Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> On 2018-12-01 12:06:36 -0500, Tom Lane wrote:
>> I wonder whether we shouldn't remove the clang aspect of the test
>> you added, ie just make it read "if on x86, you must have either
>> -fexcess-precision=standard or -msse2".

> That sounds reasonable.

>> Or should we go so far as to have configure add -msse2 automatically?

> Probably not - there's several OSs / distributions that do not yet
> require an SSE2 capable CPU. While I personally don't care much about
> such machines, I don't think it's worth desupportem them as long as
> mainstream compilers with -fexcess-precision=standard exist.

I guess I wasn't precise enough: I meant add -msse2 if on x86 and
compiler doesn't take -fexcess-precision=standard.

			regards, tom lane

Commits

  1. Error out for clang on x86-32 without SSE2 support, no -fexcess-precision.

  2. Fix 8a934d677 for libc++ and make more include order resistant.