Horton

Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Josh Berkus <josh@agliodbs.com>, Robert Haas <robertmhaas@gmail.com>, Bruce Momjian <bruce@momjian.us>, Jim Cox <shakahshakah@gmail.com>, pgsql-hackers@postgresql.org, Peter Eisentraut <peter_e@gmx.net>, David Fetter <david@fetter.org>
Date: 2010-02-23T18:47:57Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Tom Lane escribi:
>> That would be an argument for sticking this in the next CF, not for
>> applying it now --- it was submitted after the close of the last CF no?

> Sep. 29 2009?

Oh, I was thinking it had just come in recently, but looking back you're
right.  It did slip through the cracks.

However, has the patch actually been reviewed?  pg_dump is a piece of
code where it is notoriously easy for novices to do things wrong,
and this is especially true for adding output that should only come out
in particular cases.

			regards, tom lane