Horton

Re: CALL stmt, ERROR: unrecognized node type: 113 bug

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-02-12T20:19:27Z
Lists: pgsql-hackers 
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2/1/18 11:33, Pavel Stehule wrote:
>> postgres=# \sf test
>> ERROR:  cache lookup failed for type 0

> Here is a patch set that adds procedure support to \ef and \sf.

I've not read in detail, but it looks reasonable offhand, modulo
that I still don't like prorettype == 0 ;-).

I did notice a tiny typo:

-	 * with.  Hence prefer "$function$", but extend if needed.
+	 * with.  Hence prefer "$function$"/"$procedure", but extend if needed.

I think you want

+	 * with.  Hence prefer "$function$"/"$procedure$", but extend if needed.

			regards, tom lane

Commits

  1. Avoid premature free of pass-by-reference CALL arguments.

  2. Fix oversight in CALL argument handling, and do some minor cleanup.