Horton

Re: Add A Glossary

Jürgen Purtz <juergen@purtz.de>

View thread View on postgr.es
From: Jürgen Purtz <juergen@purtz.de>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Roger Harkavy <rogerharkavy@gmail.com>, pgsql-hackers@postgresql.org, Fabien COELHO <coelho@cri.ensmp.fr>, Michael Paquier <michael@paquier.xyz>
Date: 2020-04-01T07:34:41Z
Lists: pgsql-hackers, pgsql-docs 
On 31.03.20 19:58, Justin Pryzby wrote:
> On Tue, Mar 31, 2020 at 04:13:00PM +0200, Jürgen Purtz wrote:
>> Please find some minor suggestions in the attachment. They are based on
>> Corey's last patch 0001-glossary-v4.patch.
>> @@ -220,7 +220,7 @@
>>         Record</glossterm>s to the file system and creates a special
>>         checkpoint record. This process is initiated when predefined
>>         conditions are met, such as a specified amount of time has passed, or
>> -      a certain volume of records have been collected.
>> +      a certain volume of records has been collected.
> I think you're correct in that "volume" is singular.  But I think "collected"
> is the wrong world.  I suggested "written".
>
"collected" is not optimal. I suggest "created". Please avoid "written", 
the WAL records will be written when the Checkpointer is running, not 
before. So:

  "a certain volume of <glossterm>WAL records<glossterm> has been 
collected."


Every thing else is ok for me.

Kind regards, Jürgen

Commits

  1. Glossary: Add term "base backup"

  2. Minor glossary tweaks

  3. Adjust some glossary terms

  4. Fix more typos and grammar problems in the glossary

  5. Review of the glossary

  6. Add a glossary to the documentation