Re: list partition constraint shape
Amit Langote <langote_amit_f8@lab.ntt.co.jp>
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-01-29T06:22:20Z
Lists: pgsql-hackers
Fujita-san, On 2018/01/29 15:15, Etsuro Fujita wrote: > (2018/01/29 9:50), Amit Langote wrote: >> On 2018/01/26 21:31, Etsuro Fujita wrote: >>> Attached is a modified >>> version of the patch. What do you think about that? Please let me know. >>> If that is okay, I'll mark this as Ready for Committer. >> >> That looks good, thanks. > > Cool! One thing I noticed to revise the patch a bit further is to add an > assertion to make_partition_op_expr that the number of the right-hand > inputs to generate an operator expression from for list-partitioning > should be >=1; in that case we call that function if there is at least one > non-null partition value as the right-hand input, so that should be > asserted successfully there. I think the assertion is a good thing, so I > modified the patch. Ah, good call. > Updated patch attached. Because I made no changes > other than that, I'll make this as Ready for Committer. Thanks a lot for reviewing. Regards, Amit
Commits
-
Fix list partition constraints for partition keys of array type.
- 86fba2865785 10.2 landed
- 3ccdc6f9a587 11.0 landed