Horton

Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Christoph Berg <christoph.berg@credativ.de>, Andres Freund <andres@anarazel.de>, Michael Paquier <michael.paquier@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-12-21T14:22:36Z
Lists: pgsql-hackers 
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> Looks reasonable. Regarding the change to TestLib.pm, we should make
> sure that the tests have unique names. There is a small amount of
> duplication currently:

>     ./src/bin/pg_dump/t/001_basic.pl
>     ./src/bin/pg_rewind/t/001_basic.pl
>     ./src/test/modules/commit_ts/t/001_base.pl
>     ./src/test/modules/test_pg_dump/t/001_base.pl

Perhaps, but that's a separate/pre-existing problem no?  The point
of the change in my patch was just to avoid getting different
behavior in a VPATH build.

			regards, tom lane

Commits

  1. Avoid putting build-location-dependent strings into generated files.