Horton

Re: more C99 cleanup

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-11-25T05:53:55Z
Lists: pgsql-hackers 
Peter Eisentraut <peter@eisentraut.org> writes:
> On 21.11.25 17:10, Tom Lane wrote:
>> Ah, there are several.  It's not totally obvious perhaps where the
>> cause is.  I'll attach the diffs just for the archives' sake.

> For clarification, does what you are showing mean that the regression 
> tests have enough coverage of the hypot() edge cases?

We are definitely covering it.  It's just that the present tests
fail in a way that wouldn't scream "hypot is broken" to some
future hacker dealing with such a failure.  Not sure if that's
worth worrying about; but I'd lean to not worrying unless you
commit and we see such failures in the buildfarm.

			regards, tom lane

Commits

  1. Update comment related to C99

  2. Fix pg_isblank()

  3. Replace internal C function pg_hypot() by standard hypot()

  4. Remove obsolete comment

  5. Report timezone offset in pg_dump/pg_dumpall