Re: remove pg_restrict workaround
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-10-15T13:58:33Z
Lists: pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes: > When in C11 mode, MSVC supports the standard "restrict" keyword, so we > don't need the workaround with using "pg_restrict" instead anymore. > (Just for clarification, restrict is a C99 feature, but MSVC only > accepts it properly in C11 mode.) So I'm proposing to remove that > workaround here, so that code can use the standard restrict keyword > without having to worry about the alternative spelling. Won't this break extensions that are using pg_restrict? Sure, they could update their code, but then maybe it wouldn't work anymore against previous branches. Seems like it'd be better to leave pg_restrict in place (for awhile anyway) but always #define it as "restrict". I don't mind ceasing to use it within our own tree though. regards, tom lane
Commits
-
Revert "Replace pg_restrict by standard restrict"
- fa16e7fd8488 19 (unreleased) landed
-
Replace pg_restrict by standard restrict
- f0f2c0c1aef9 19 (unreleased) landed
-
Remove meaninglist restrict qualifiers
- 64d2b0968ea4 19 (unreleased) landed