Re: Allow pg_read_all_stats to read pg_stat_progress_*
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Magnus Hagander <magnus@hagander.net>,
"Andrey M. Borodin" <x4mmm@yandex-team.ru>,
Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-04-20T14:12:11Z
Lists: pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes: > Ugh. That doesn't make it correct though.. We really should be using > has_privs_of_role() for these cases (and that goes for all of the > default role cases- some of which are correct and others are not, it > seems). I have a different concern about this patch: while reading statistical values is fine, do we REALLY want pg_read_all_stats to enable pg_stat_get_activity(), ie viewing other sessions' command strings? That opens security considerations that don't seem to me to be covered by the description of the role. regards, tom lane
Commits
-
Allow pg_read_all_stats to access all stats views again
- d0bb66572e33 10.13 landed
- 3d4652f67d1f 11.8 landed
- 212e712a5eed 12.3 landed
- 7e4e574744c1 13.0 landed