Horton

Re: 001_password.pl fails with --without-readline

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>
Cc: Soumya S Murali <soumyamurali.work@gmail.com>, pgsql-hackers@postgresql.org
Date: 2026-01-19T18:56:49Z
Lists: pgsql-hackers 
=?UTF-8?B?T2xlZyBUc2VsZWJyb3Zza2l5?= <o.tselebrovskiy@postgrespro.ru> writes:
>> I fetched all refs and tags locally and reset my tree to a clean
>> origin/master, but I am unable to locate commit 34740b9 in my
>> repository

> Maybe your origin is out-of-date or is just different?
> What does ‘​git remote get-url origin’ say in your local repository?

34740b9 is there for me, but it's less than a day old:

commit 34740b90bc123d645a3a71231b765b778bdcf049
Author: Richard Guo <rguo@postgresql.org>
Date:   Mon Jan 19 11:13:23 2026 +0900

    Fix unsafe pushdown of quals referencing grouping Vars

However, none of these patches are touching any recently-modified
code AFAIK, so they should apply cleanly even to a slightly out
of date tree.  I suspect Soumya's failure-to-apply problem has
a different cause.  The patches I posted were just "git diff"
output, without a commit message, so I believe you can't use
"git am" to apply them.  Hoary old "patch -p1" ought to work
though.

			regards, tom lane

Commits

  1. Make psql/t/030_pager.pl more robust.

  2. Improve guards against false regex matches in BackgroundPsql.pm.

  3. Fix unsafe pushdown of quals referencing grouping Vars

  4. tests: BackgroundPsql: Fix potential for lost errors on windows