Re: Clarify how triggers relate to transactions
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: him@nathanmlong.com, pgsql-docs@lists.postgresql.org
Date: 2021-07-30T20:20:23Z
Lists: pgsql-hackers, pgsql-docs
Attachments
- 0001-Document-how-triggers-interact-with-transactions-2.patch (text/x-diff) patch 0001
Laurenz Albe <laurenz.albe@cybertec.at> writes: > On Wed, 2021-04-28 at 13:24 +0200, Laurenz Albe wrote: >> On Tue, 2021-04-27 at 14:26 +0000, PG Doc comments form wrote: >>> If I understand correctly, it would be helpful to add this sentence or a >>> corrected version of it: "Triggers always execute in the same transaction as >>> the triggering event, and if a trigger fails, the transaction is rolled >>> back." >> Good idea in principle, but I'd put that information on >> https://www.postgresql.org/docs/current/trigger-definition.html > Here is a proposed patch for this. I think this is a good idea, but I felt like you'd added the extra sentences in not-terribly-well-chosen places. For instance, your first addition in trigger.sgml is adding to a para that talks about triggers for tables, while the next para talks about triggers for views. So it seems unclear whether the statement is meant to apply to view triggers too. I think it'd work out best to make this a separate para after the one that defines before/after/instead-of triggers. How do you like the attached? regards, tom lane
Commits
-
Doc: clarify how triggers relate to transactions.
- 95bc40f880a6 14.0 landed
- 469150a240dd 15.0 landed