Re: Should contrib modules install .h files?
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>,
Andrew Gierth <andrew@tao11.riddles.org.uk>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-07-31T21:53:19Z
Lists: pgsql-hackers
Peter Geoghegan <pg@bowt.ie> writes: > On Tue, Jul 31, 2018 at 1:17 PM, Andres Freund <andres@anarazel.de> wrote: >> I'm a bit surprised that you decided to push to the 11 branch - the >> consensus in this thread seem to have gone the other way by my read? >> Given that that's the rule, and pushing non-fixes is the exception, I'm >> not particularly ok with just ignoring that? > +1 By my count of people expressing opinions, we had Michael -1, Stephen -1, me -0.1 or so, Alvaro +1, Peter -1, presumably +1 from Andrew; and Andres made a comment about not waiting, which perhaps Andrew read as a +1 for backpatching. So it's not unreasonable for Andrew to have decided that it was about tied. Nonetheless, it does seem like a feature and we're past feature freeze, so the default assumption ought to be "no backpatch" IMO. regards, tom lane
Commits
-
Fix out-of-tree build for transform modules.
- f1ca5a654d5d 11.0 landed
- 60f6756f9225 12.0 landed
-
Provide for contrib and pgxs modules to install include files.
- df163230b92b 12.0 landed
- d06eebce5fa4 11.0 landed