Horton

Re: BUG #19450: Where is checksum_block.inc.c after master install?

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <johncnaylorls@gmail.com>
Cc: rekgrpth@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2026-04-06T02:50:54Z
Lists: pgsql-bugs 
John Naylor <johncnaylorls@gmail.com> writes:
>> There is no checksum_block.inc.c after master install

> I'll look into that. What broke, so I can reproduce?

src/include/Makefile knows what it's supposed to install out
of that subtree, and it thinks storage/*.h is sufficient.
I didn't check to see if the meson system has the same oversight.

One could argue that the real bug is having put a .c file into
the include/ tree in the first place.  Why was it done like that?
Couldn't it be a .h file?

			regards, tom lane

Commits

  1. Use .h for the file containing the page checksum code fragment