Horton
Menu

Re: Typos in the code and README

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alexander Lakhin <exclusion@gmail.com>, David Rowley <dgrowleyml@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2026-01-04T23:32:14Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Jan 01, 2026 at 10:00:00AM +0200, Alexander Lakhin wrote:
>> replace_s(..., int * adjustment) -> replace_s(..., int * adjptr)

> Updating this one contradicts with the upstream sources, see
> b464e51ab32f that has done the opposite switch.

It looks like upstream has fixed the problem -- not by making the
two instances match, but by removing the parameter altogether
(see their recent commit 16edd5abb9ce7386e9208b998cd43524480cb801).

Maybe it's time for another sync with upstream?  But if we don't
feel like doing that right now, I think Alexander's proposed patch
is okay.  It won't make the next sync any harder.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix typo in planner.c

  2. Fix meson build of snowball code.

  3. Update to latest Snowball sources.

  4. Remove unneeded defines from pg_config.h.in

  5. Fix typos and inconsistencies in code and comments

  6. Fix a few more duplicate words in comments

  7. Fix a few duplicate words in comments

  8. Fix typos and grammar in the code

  9. Fix an assortment of spelling mistakes and typos

  10. Fix inconsistent LWLock tranche name "CommitTsSLRU"

  11. Fix typos in code comments and test data

  12. Fix typos and grammar in code comments and docs

  13. Fix a series of typos and outdated references

  14. Optimize InvalidateAttoptCacheCallback() and TypeCacheTypCallback()

  15. pg_upgrade: Remove unused macro

  16. pgcrypto: Remove unused binary from clean target

  17. Fix an assortment of typos

  18. Fix duplicated consecutive words in comments

  19. Remove unused function prototype

  20. Fix incorrect parameter name in prototype

  21. Fix typos and duplicate words

  22. Speedup 2PC recovery by skipping two phase state files in normal path

  23. Two-phase commit. Original patch by Heikki Linnakangas, with additional