Horton

Re: CALL stmt, ERROR: unrecognized node type: 113 bug

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>, "David G. Johnston" <david.g.johnston@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, Postgres hackers <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>
Date: 2018-02-12T20:06:18Z
Lists: pgsql-hackers 
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2/11/18 01:10, Tom Lane wrote:
>> Yeah.  I was under the impression that Peter was looking into that ...
>> [ digs... ] see
>> https://www.postgresql.org/message-id/80ee1f5c-fa9d-7285-ed07-cff53d4f4858@2ndquadrant.com

> Yeah that's still pending, but there wasn't a whole lot of reaction in
> that thread.

I think it's probably a good idea, but you hadn't finished the client
end of the patch.  Since the main argument against doing this would
probably be about client-side breakage, we need to see how big that
impact will be before we make a final decision.

			regards, tom lane

Commits

  1. Avoid premature free of pass-by-reference CALL arguments.

  2. Fix oversight in CALL argument handling, and do some minor cleanup.