Horton

Thread

Commits

  1. Use <unnamed> for name of unnamed portal's memory context

  1. Use <unnamed> for name of unnamed portal's memory context

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-09-05T06:14:14Z

    I propose the attached little patch to set the name of the memory 
context of an unnamed portal to "<unnamed>" instead of just an empty 
string.  Otherwise the debug memory context dump looks a little 
confusing.  We use this convention elsewhere for making unnamed 
statements etc. more clearly visible.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  2. Re: Use <unnamed> for name of unnamed portal's memory context

    Pavel Stehule <pavel.stehule@gmail.com> — 2020-09-05T06:24:13Z

    so 5. 9. 2020 v 8:14 odesílatel Peter Eisentraut <
peter.eisentraut@2ndquadrant.com> napsal:

> I propose the attached little patch to set the name of the memory
> context of an unnamed portal to "<unnamed>" instead of just an empty
> string.  Otherwise the debug memory context dump looks a little
> confusing.  We use this convention elsewhere for making unnamed
> statements etc. more clearly visible.
>

+1

Pavel

>
> --
> Peter Eisentraut              http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>

  3. Re: Use <unnamed> for name of unnamed portal's memory context

    Julien Rouhaud <rjuju123@gmail.com> — 2020-09-05T06:55:06Z

    On Sat, Sep 5, 2020 at 8:25 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:
>
> so 5. 9. 2020 v 8:14 odesílatel Peter Eisentraut <peter.eisentraut@2ndquadrant.com> napsal:
>>
>> I propose the attached little patch to set the name of the memory
>> context of an unnamed portal to "<unnamed>" instead of just an empty
>> string.  Otherwise the debug memory context dump looks a little
>> confusing.  We use this convention elsewhere for making unnamed
>> statements etc. more clearly visible.
>
>
> +1

+1 too, and obviously patch looks good.

  4. Re: Use <unnamed> for name of unnamed portal's memory context

    Tom Lane <tgl@sss.pgh.pa.us> — 2020-09-05T15:10:20Z

    Julien Rouhaud <rjuju123@gmail.com> writes:
> +1 too, and obviously patch looks good.

The adjacent comment needs updating.

			regards, tom lane

  5. Re: Use <unnamed> for name of unnamed portal's memory context

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-09-08T15:25:48Z

    On 2020-09-05 17:10, Tom Lane wrote:
> Julien Rouhaud <rjuju123@gmail.com> writes:
>> +1 too, and obviously patch looks good.
> 
> The adjacent comment needs updating.

committed with that change

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services