Horton

Re: Bug in UTF8-Validation Code?

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Jeff Davis <pgsql@j-davis.com>, Michael Fuhr <mike@fuhr.org>, Mario Weilguni <mweilguni@sime.com>, "Joshua D. Drake" <jd@commandprompt.com>, Albe Laurenz <all@adv.magwien.gv.at>, pgsql-hackers@postgresql.org
Date: 2007-03-17T16:10:06Z
Lists: pgsql-hackers 
Andrew Dunstan <andrew@dunslane.net> writes:
> Last year Jeff suggested adding something like:
>     pg_verifymbstr(string,strlen(string),0);
> to each relevant input routine. Would that be an acceptable solution?

The problem with that is that it duplicates effort: in many cases
(especially COPY IN) the data's already been validated.  I'm not sure
how to fix that, but I think you'll get some push-back if you double
the encoding verification work in COPY for nothing.

Given that we are moving away from backslash-enabled literals, I'm
not as convinced as some that this must be fixed...

			regards, tom lane