Re: missing rename support

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Ali Dar <ali.munir.dar@gmail.com>, pgsql-hackers@postgresql.org
Date: 2013-01-18T18:54:58Z
Lists: pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:
> * Ali Dar (ali.munir.dar@gmail.com) wrote:
>> Find attached an initial patch for ALTER RENAME RULE feature. Please
>> note that it does not have any documentation yet.

> Just took a quick look through this.  Seems to be alright, but why do we
> allow renaming ON SELECT rules at all, given that they must be named
> _RETURN?  My thinking would be to check for that case and error out if
> someone tries it.

Agreed, we should exclude ON SELECT rules.

> You should try to keep variables lined up:

pgindent is probably a better answer than trying to get this right
manually.

			regards, tom lane