Re: mkid reference
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Magnus Hagander <magnus@hagander.net>, Bruce Momjian <bruce@momjian.us>,
PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2021-01-22T18:07:36Z
Lists: pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes: >> On 22 Jan 2021, at 12:56, Magnus Hagander <magnus@hagander.net> wrote: >> And maybe even more interestnig -- is there a point to this whole >> make_diff directory at all in these days of git? Or should we just >> remove it rather than try to fix it? > There's also src/tools/make_mkid which use this mkid tool. +1 for removing. > If anything, it seems better replaced by extended documentation on the existing > wiki article [0] on how to use "git format-patch". I found man pages for mkid online --- it's apparently a ctags-like code indexing tool, not something for patches. So maybe Bruce still uses it, or maybe not. But as long as we've also got make_ctags and make_etags in there, I don't have a problem with leaving make_mkid. make_diff, on the other hand, certainly looks like technology whose time has passed. I wonder about pgtest, too. regards, tom lane
Commits
-
Remove make_diff set of tools
- 8a337b0ed21c 14.0 landed