Re: flinfo NULL in DirectFunctionCall callee?

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Cc: pgsql-general@lists.postgresql.org
Date: 2019-08-26T18:34:07Z
Lists: pgsql-general
Paul A Jungwirth <pj@illuminatedcomputing.com> writes:
> On Mon, Aug 26, 2019 at 8:12 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yes, per the comment on those functions:
>> * These are for invocation of a specifically named function with a
>> * directly-computed parameter list.  Note that neither arguments nor result
>> * are allowed to be NULL.  Also, the function cannot be one that needs to
>> * look at FmgrInfo, since there won't be any.

> Thanks Tom! Alas I saw that same comment in fmgr.h but it was missing
> the last sentence.

Oh, hm, that's not very nice.  Fixed.

> Would you like a patch updating it there? Is that
> the kind of thing you make CF entries for?

Not really worth the overhead, for something as simple as this.

			regards, tom lane



Commits

  1. Make comment in fmgr.h match the one in fmgr.c.