Re: [postgresql 10 beta3] unrecognized node type: 90

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Adam, Etienne (Nokia-TECH/Issy Les Moulineaux)" <etienne.adam@nokia.com>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-bugs@postgresql.org, "Duquesne, Pierre (Nokia-TECH/Issy Les Moulineaux)" <pierre.duquesne@nokia.com>
Date: 2017-08-11T15:59:14Z
Lists: pgsql-bugs, pgsql-hackers
"Adam, Etienne (Nokia-TECH/Issy Les Moulineaux)" <etienne.adam@nokia.com> writes:
> ERROR:  XX000: unrecognized node type: 90
> LOCATION:  ExecReScan, execAmi.c:284

(gdb) p (NodeTag) 90
$1 = T_GatherMergeState

So, apparently somebody wrote ExecReScanGatherMerge, but never bothered
to plug it into ExecReScan.  From which we may draw depressing conclusions
about how much it's been tested.

Thanks for the report!

			regards, tom lane


Commits

  1. Separate reinitialization of shared parallel-scan state from ExecReScan.

  2. Restore test case from a2b70c89ca1a5fcf6181d3c777d82e7b83d2de1b.

  3. Force rescanning of parallel-aware scan nodes below a Gather[Merge].

  4. Fix ExecReScanGatherMerge.

  5. Add missing call to ExecReScanGatherMerge.