Re: On non-Windows, hard depend on uselocale(3)

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: Tristan Partin <tristan@neon.tech>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2023-11-19T22:36:24Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert "Tidy up locale thread safety in ECPG library."
- 3c8e463b0d88 18.0 landed
Tidy up locale thread safety in ECPG library.
- 8e993bff5326 18.0 landed
Revert "Blind attempt to fix _configthreadlocale() failures on MinGW."
- a62d90f2e5cb 18.0 landed
Require ucrt if using MinGW.
- 1758d4244616 18.0 landed
Remove configure check for _configthreadlocale().
- f1da075d9a03 18.0 landed
Simplify checking for xlocale.h
- 9c2a6c5a5f4b 18.0 landed
All supported systems have locale_t.
- 8d9a9f034e92 17.0 cited

Thomas Munro <thomas.munro@gmail.com> writes:
> BTW is this comment in snprintf.c true?

>  * 1. No locale support: the radix character is always '.' and the '
>  * (single quote) format flag is ignored.

> It is in the backend but only because we nail down LC_NUMERIC early
> on, not because of any property of snprintf.c, no?

Hmm, the second part of it is true.  But given that we punt float
formatting to libc, I think you are right that the first part
depends on LC_NUMERIC being frozen.

			regards, tom lane