Re: Debug message in RemoveOldXlogFiles

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-06-18T13:59:57Z
Lists: pgsql-hackers
Simon Riggs <simon@2ndQuadrant.com> writes:
> I think it would be more helpful if it showed a filename. Shall we
> change that?

The point of the committed change was to make that message look like
every other one in xlog.c that shows a log/seg pair.

If we were going to start redesigning the printout format, I'd
personally vote for something that makes it easier to compare LSN
printouts and log/seg printouts, like maybe printing log/seg as the
file's starting LSN.  But the main point is that considering any one of
these messages in isolation is the wrong approach.  In any case it's a
bit late to be bikeshedding this for 9.0.

			regards, tom lane