Re: libpq OpenSSL and multithreading

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-12T15:05:05Z
Lists: pgsql-hackers
> On 29 Oct 2025, at 10:41, Peter Eisentraut <peter@eisentraut.org> wrote:
> On 22.10.25 10:59, Daniel Gustafsson wrote:

>>> On 1 Sep 2025, at 07:27, Peter Eisentraut <peter@eisentraut.org> wrote:
>>> I suggest that instead of adding the context to the Port structure, make a separate context struct for this purpose, for example:
>> Fair enough, done in the attached.
> 
> This looks good to me.  (I would not have the CallbackErr typedef, since that additional abstraction doesn't buy anything.  But it's a small difference.)

Thanks, I removed the typedef and went ahead with this patch.

>> (sidenote; if our thread
>> local store code will use TLS then be-secure-openssl.c will be challenging to
>> read =)).
> 
> Yes, let's rename it to SSL to avoid this. ;-)

Touché! =)

--
Daniel Gustafsson




Commits

  1. libpq: threadsafety for SSL certificate callback