Re: Rethinking -L switch handling and construction of LDFLAGS
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-04-01T19:42:13Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > On 2018-04-01 13:55:05 -0400, Tom Lane wrote: >> I'm hesitant to do that because LDFLAGS is a name known to make's >> default rules, and I don't want to bet that we're not relying on >> those default rules anywhere. > FWIW, postgres builds cleanly with -r -R in MAKELAGS. That's pretty hard to believe. Why would we bother to override every default rule? Even if it's true today, I would not accept it as project policy that we must do so. Perhaps more to the point, I would strongly object to any design in which the standard Make variables don't mean what the default rules expect them to mean. That's just a recipe for confusing people and creating hard-to-spot bugs. regards, tom lane
Commits
-
Prevent accidental linking of system-supplied copies of libpq.so etc.
- dddfc4cb2edc 11.0 landed