Horton

Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling)

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Michael Paquier <michael.paquier@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2017-05-09T14:29:16Z
Lists: pgsql-hackers 
On 5/9/17 03:27, Masahiko Sawada wrote:
> I think we should change tab-completion support for that as well.
> 
> diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
> index 183fc37..046fdd5 100644
> --- a/src/bin/psql/tab-complete.c
> +++ b/src/bin/psql/tab-complete.c
> @@ -2684,7 +2684,7 @@ psql_completion(const char *text, int start, int end)
> 
>         /* DROP SUBSCRIPTION */
>         else if (Matches3("DROP", "SUBSCRIPTION", MatchAny))
> -               COMPLETE_WITH_LIST2("DROP SLOT", "NODROP SLOT");
> +               COMPLETE_WITH_LIST2("CASCADE", "RESTRICT");
> 
>  /* EXECUTE */
>         else if (Matches1("EXECUTE"))

Thanks for pointing that out.  I just moved it under the generic DROP
support section.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Remove the NODROP SLOT option from DROP SUBSCRIPTION