Horton

Re: [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>, Noah Misch <noah@leadboat.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-05-30T13:41:57Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
>>>> I'm not really for doing it that way, but I'm willing to apply the fix
>>>> if there's consensus for your position.  Anybody else have an opinion?

> +1 from me, too.  I don't see that there's enough advantage in
> avoiding a catversion bump to justify leaving this footgun behind.

The consensus seems pretty clear.  I'll make it so.

			regards, tom lane

Commits

  1. Fix omission of locations in outfuncs/readfuncs partitioning node support.

  2. Code review focused on new node types added by partitioning support.