Re: [PATCH] Handle out-of-range timestamps in timestamptz_to_str()

> On Oct 15, 2025, at 16:54, Алена Васильева <gorcom2012@gmail.com> wrote:
> 
> Hello,
> 
> The function timestamptz_to_str() in src/bin/pg_waldump/compat.c does not
> handle the case when localtime() returns NULL, which can happen for timestamps
> that are out of the supported time_t range on some platforms.
> 
> This patch adds a simple check for a NULL return value and ensures that the
> function returns a clear error string "(timestamp out of range)" instead of
> causing undefined behavior or a crash.
> 
> 
I think we can just return a static const string, without copying the string into “buf" as the function returns a “const char *”.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/