Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jürgen Strobel <juergen+postgresql@strobel.info>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-11-12T23:57:19Z
Lists: pgsql-bugs, pgsql-hackers
=?UTF-8?Q?J=c3=bcrgen_Strobel?= <juergen+postgresql@strobel.info> writes: > On 2018-11-12 17:33, Tom Lane wrote: >> I'm not entirely convinced that I buy that argument, especially not in >> a case like this where it introduces logical inconsistencies where there >> otherwise wouldn't be any. > I think I missed something, what are the *introduced* logical problems? What to do if a partition introduces a default value that would force re-routing to some other partition. > Apart from implementation issues the only logical problems I see are if > you allow to change defaults of the partition key columns, and these are > problematic (nonsensical really) in either case. Just claiming that it's nonsensical doesn't fix the problem. Also, it is neither problematic nor nonsensical for the root to provide defaults for partition key columns. So if we go this route, we are giving up useful behavior (key-column defaults on the root) for useless behavior (key-column defaults on the partitions). regards, tom lane
Commits
-
Revise attribute handling code on partition creation
- e0c05bf4a7e6 11.2 landed
- 705d433fd5e2 12.0 landed
- 21c9e4973cec 10.7 landed