Re: Idea for minor tstore optimization
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Neil Conway <neilc@samurai.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2008-02-27T22:48:53Z
Lists: pgsql-hackers
Neil Conway <neilc@samurai.com> writes: > I notice that several of the call sites of tuplestore_puttuple() start > with arrays of datums and nulls, call heap_form_tuple(), and then switch > into the tstore's context and call tuplestore_puttuple(), which > deep-copies the HeapTuple into the tstore. ISTM it would be faster and > simpler to provide a tuplestore_putvalues(), which just takes the datum > + nulls arrays and avoids the additional copy. Seems reasonable. Check whether tuplesort should offer the same, while you are at it. regards, tom lane