Re: Patch to add a primary key using an existing index

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Steve Singer <ssinger_pg@sympatico.ca>

Cc: Gurjeet Singh <singh.gurjeet@gmail.com>, PGSQL Hackers <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter_e@gmx.net>, Robert Haas <robertmhaas@gmail.com>, r t <pgsql@xzilla.net>, Itagaki Takahiro <itagaki.takahiro@gmail.com>

Date: 2011-01-24T18:00:22Z

Lists: pgsql-hackers

Steve Singer <ssinger_pg@sympatico.ca> writes:
> src/backend/parser/parse_utilcmd.c: 1452
> Your calling strdup on the attribute name.  I don't have a good enough 
> grasp on the code to be able to trace this through to where the memory 
> gets free'd.  Does it get freed? Should/could this be a call to pstrdup

strdup() is pretty much automatically wrong in the parser, not to
mention most of the rest of the backend.  pstrdup is likely what was
meant.  If that's the only issue then I don't see any need to wait on
the author, so will take this one.

			regards, tom lane