Re: pgindent vs dtrace on macos

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Daniel Gustafsson <daniel@yesql.se>

Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2020-09-21T18:55:37Z

Lists: pgsql-hackers

Attachments

rename-C-functions-to-avoid-pgindent-funnies.patch (text/x-diff) patch

Oh wait, I forgot about the fmgrprotos.h discrepancy.

I wrote:
> It strikes me that a low-cost workaround would be to rename these
> C functions.  There's no law that their C names must match the
> SQL names.

Here's a proposed patch to fix it that way.

			regards, tom lane

Commits

Exclude fmgrprotos.h from pgindent processing.
- c4133ec169df 14.0 landed
Fix a few more generator scripts to produce pgindent-clean output.
- f859c2ffa01d 14.0 landed
Further improve pgindent's list of file exclusions.
- 74d4608f506b 14.0 landed
Improve formatting of create_help.pl and plperl_opmask.pl output.
- add105840b67 14.0 landed