Re: Typo/wording on https://www.postgresql.org/docs/current/catalog-pg-class.html
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: mpnash@google.com, pgsql-docs@lists.postgresql.org
Date: 2023-09-22T17:04:02Z
Lists: pgsql-docs
Attachments
- tweak-description-of-pg_class.patch (text/x-diff) patch
I wrote: > "Most" here is good English, although I concede it's a slightly > old-fashioned usage. Maybe it'd be clearer to just remove the > word altogether. > If we were going to touch this sentence I'd worry about some other > things too. Use of "catalogs" as a verb is probably not the greatest > choice right here, since one could easily think that the verb is > missing and what was meant was "pg_class lists catalogs, [user] > tables, and ...". Also, I think that the reference to special > relations is obsolete --- we don't list any relkind for that anymore. > What probably does deserve to be called out in place of those is > composite types, since their appearance in pg_class might be pretty > surprising to newbies. Hmm, I must have been looking at some old version of the docs, because when I went to prepare a draft patch I found that those last couple of points were addressed some time ago. I think we just need some slightly better wording here rather than any change of technical content. I propose the attached. (I also modified the para's last sentence to speak of "kind" not "type", for consistency with the relkind field name and the rest of the para.) regards, tom lane
Commits
-
Doc: copy-edit the introductory para for the pg_class catalog.
- d7cc7184ccca 12.17 landed
- bd82b8d9b213 15.5 landed
- bbb9bec11c58 14.10 landed
- 755eb44d3c79 17.0 landed
- 7060f8023fcd 13.13 landed
- 2a47c0453528 11.22 landed
- 2290a13827dc 16.1 landed
-
Update info about relkind and pg_type entries for composite-types patch.
- 83501ef4ca61 7.3.1 cited