Re: pgsql: Add support for hyperbolic functions, as well as log10().
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Lætitia Avrot <laetitia.avrot@gmail.com>
Date: 2019-03-14T02:39:03Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > On Wed, Mar 13, 2019 at 8:49 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Meh. As I said before, we're not in the business of improving on what >> libm does --- if someone has a beef with the results, they need to take >> it to their platform's libm maintainer, not us. The point of testing >> this at all is just to ensure that we've wired up the SQL functions >> to the library functions correctly. > Pretty sure we don't even need a test for that. asinh() isn't going > to call creat() by mistake. No, but that's not the hazard. I have a very fresh-in-mind example: at one point while tweaking Laetitia's patch, I'd accidentally changed datanh so that it called tanh not atanh. The previous set of tests did not reveal that :-( regards, tom lane
Commits
-
Further adjust the tests for the hyperbolic functions.
- c43ecdee0fff 12.0 landed
-
Adjust the tests for the hyperbolic functions.
- c015f853bf59 12.0 landed
-
Rethink how to test the hyperbolic functions.
- c6f153dcfebc 12.0 landed
-
Add support for hyperbolic functions, as well as log10().
- f1d85aa98ee7 12.0 cited