Horton

Re: Hide exposed impl detail of wchar.c

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Jubilee Young <workingjubilee@gmail.com>, pgsql-hackers@postgresql.org, andres@anarazel.de, johncnaylorls@gmail.com
Date: 2024-01-26T18:24:19Z
Lists: pgsql-hackers 
Nathan Bossart <nathandbossart@gmail.com> writes:
> I see that I was planning on back-patching this to v16, but since
> is_valid_ascii() was introduced in v15, I'm wondering if it'd be better to
> back-patch it there so that is_valid_ascii() lives in the same file for all
> versions where it exists.  Thoughts?

Yeah, if we're going to back-patch at all, that probably makes sense.

			regards, tom lane

Commits

  1. Move is_valid_ascii() to ascii.h.

  2. Use SSE2 in is_valid_ascii() where available.