Re: [PATCH] pgindent truncates last line of files missing a trailing newline
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
Andrew Dunstan <andrew@dunslane.net>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-03-26T16:29:46Z
Lists: pgsql-hackers
Attachments
- v3-0001-Fix-pgindent-truncates-last-line-of-files.patch (text/x-diff) patch v3-0001
Akshay Joshi <akshay.joshi@enterprisedb.com> writes: > I have addressed the review comments from Andrew. > Attached is the v2 patch, ready for review. I'm not sure I want to expend the brain cells to figure out whether this is a correct/complete patch. If pg_bsd_indent were less of an undercommented spaghetti-code nightmare, maybe fixing it here would be reasonable. But as things stand, why don't we just fix this in the perl wrapper, as attached? (In any case, I'm not in favor of adding a test case, because that would require putting a trailing-newline-less .c file into our tree. At best there would be a permanent hazard of something "fixing" the file.) regards, tom lane
Commits
-
pgindent: ensure all C files end with a newline.
- 79ac82125ef6 19 (unreleased) landed