Horton

Re: Extracting cross-version-upgrade knowledge from buildfarm client

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-01-14T15:47:35Z
Lists: pgsql-hackers 
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-01-13 Fr 19:48, Tom Lane wrote:
>> Attached are two patches, one for PG git and one for the buildfarm
>> client, that create a working POC for this approach.

> OK, we've been on parallel tracks (sorry about that). Let's run with
> yours, as it covers more ground.

Cool.

> One thing I would change is that your adjust_database_contents tries to
> make the adjustments rather than passing back a set of statements.

Agreed.  I'd thought maybe adjust_database_contents would need to
actually interact with the target DB; but experience so far says
that IF EXISTS conditionality is sufficient, so we can just build
a static list of statements to issue.  It's definitely a simpler
API that way.

> I also tried to remove a lot of the ugly release tag processing,
> leveraging our PostgreSQL::Version gadget. I think that's worthwhile too.

OK, I'll take a look at that and make a new draft.

			regards, tom lane

Commits

  1. Compare only major versions in AdjustUpgrade.pm

  2. Get rid of the "new" and "old" entries in a view's rangetable.

  3. Create common infrastructure for cross-version upgrade testing.