Horton

Re: 8.0b4: COMMIT outside of a transaction echoes

Oliver Elphick <olly@lfix.co.uk>

View thread
From: Oliver Elphick <olly@lfix.co.uk>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: Ian Barwick <barwick@gmail.com>, pgsql-hackers@postgresql.org
Date: 2004-10-27T14:59:21Z
Lists: pgsql-hackers 
On Tue, 2004-10-26 at 21:42 -0400, Bruce Momjian wrote:
> > test=> begin;
> > BEGIN
> > test=> commit;
> > COMMIT
> > test=> commit;
> > WARNING:  there is no transaction in progress
> > ROLLBACK
> > 
> > Is there any reason ROLLBACK and not COMMIT is echoed here?
> 
> Because the transaction was not committed, but rather rolled back.

It's still a misleading message; in those circumstances, how about
returning "NO ACTION" instead?

-- 
Oliver Elphick                                          olly@lfix.co.uk
Isle of Wight                              http://www.lfix.co.uk/oliver
GPG: 1024D/A54310EA  92C8 39E7 280E 3631 3F0E  1EC0 5664 7A2F A543 10EA
                 ========================================
     "If a man abide not in me, he is cast forth as a  
      branch, and is withered; and men gather them, and cast
      them into the fire, and they are burned."             
                                             John 15:6