Re: problem with RETURNING and update row movement

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
Cc: David Steele <david@pgmasters.net>, Michael Paquier <michael@paquier.xyz>, Etsuro Fujita <etsuro.fujita@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-04-22T15:49:10Z
Lists: pgsql-hackers
Amit Langote <amitlangote09@gmail.com> writes:
> I think we should also add slot != srcSlot to this condition.

Good idea, should save useless comparisons of identical tupdescs.
Done.

>> (I've not looked at porting this to v12 or v11 yet.)

> I did that; patches attached.  (I haven't changed them to incorporate
> the above comment though.)

Thanks for that, saved me some work.  I've pushed these.

			regards, tom lane



Commits

  1. Fix bugs in RETURNING in cross-partition UPDATE cases.

  2. postgres_fdw: Clean up handling of system columns.