Re: src/port/snprintf.c: Optimize the common base=10 case in fmtint
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>,
Arjan van de Ven <arjan@linux.intel.com>, pgsql-hackers@postgresql.org
Date: 2021-10-26T18:33:08Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > On 2021-10-26 13:51:55 -0400, Tom Lane wrote: >> I'd be inclined to just hard-wire the three allowed cases, and not have >> an arbitrary-divisor code path at all. > Yea, I came to the same conclusion. But I'd implement it by moving the > division into a separate inline function called from the switch. I tested that > locally and it works, but I got sidetracked by [1]. Uh, why not just a "switch (base)" around three copies of the loop? Don't overthink this. regards, tom lane
Commits
-
Speed up printing of integers in snprintf.c.
- 3c17926eedd5 15.0 landed